fix(elbv2): correct wrong timeout validation #26031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Jun 17, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
tmyoda
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
colifran
reviewed
Jun 20, 2023
packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-target-group.ts
Show resolved
Hide resolved
colifran
reviewed
Jun 20, 2023
packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-target-group.ts
Show resolved
Hide resolved
|
@tmyoda awesome job with this! I left a few minor comments that I'd like to double check with you. |
colifran
reviewed
Jun 21, 2023
packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-target-group.ts
Show resolved
Hide resolved
|
Hi @colifran |
colifran
approved these changes
Jun 26, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
lukey-aleios
pushed a commit
to lukey-aleios/aws-cdk
that referenced
this pull request
Jun 30, 2023
Following the update of Network Load Balancer (NLB) in November 2022, the range for setting HealthCheckTimeoutSeconds for NLB is now between 2 and 120 seconds. However, the CDK has yet to be updated to reflect this change. https://aws.amazon.com/about-aws/whats-new/2022/11/elastic-load-balancing-capabilities-application-availability/ https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html This PR addresses this by modifying the validation, enabling us to set the HealthCheckTimeoutSeconds for the NLB. I have modified and added the following validation in this PR: - Ensure that the HealthCheckTimeoutSeconds is between 2 and 120. - Ensure that HealthCheckTimeoutSeconds is not greater than HealthCheckIntervalSeconds. Closes aws#26023. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
lukey-aleios
pushed a commit
to lukey-aleios/aws-cdk
that referenced
this pull request
Jun 30, 2023
Following the update of Network Load Balancer (NLB) in November 2022, the range for setting HealthCheckTimeoutSeconds for NLB is now between 2 and 120 seconds. However, the CDK has yet to be updated to reflect this change. https://aws.amazon.com/about-aws/whats-new/2022/11/elastic-load-balancing-capabilities-application-availability/ https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html This PR addresses this by modifying the validation, enabling us to set the HealthCheckTimeoutSeconds for the NLB. I have modified and added the following validation in this PR: - Ensure that the HealthCheckTimeoutSeconds is between 2 and 120. - Ensure that HealthCheckTimeoutSeconds is not greater than HealthCheckIntervalSeconds. Closes aws#26023. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the update of Network Load Balancer (NLB) in November 2022, the range for setting HealthCheckTimeoutSeconds for NLB is now between 2 and 120 seconds. However, the CDK has yet to be updated to reflect this change.
https://aws.amazon.com/about-aws/whats-new/2022/11/elastic-load-balancing-capabilities-application-availability/
https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html
This PR addresses this by modifying the validation, enabling us to set the HealthCheckTimeoutSeconds for the NLB.
I have modified and added the following validation in this PR:
Closes #26023.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license