Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): LogRetention Custom Resource does not use Node18 #26609

Merged
merged 21 commits into from
Aug 3, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Aug 2, 2023

Migrate the LogRetention Custom Resource to AWS SDK v3.

Part of a fix for #26461


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 2, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 2, 2023 17:20
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 2, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain force-pushed the mrgrain/fix/log-retention-v3 branch from ef2ebd6 to 7f47465 Compare August 3, 2023 07:17
@mrgrain mrgrain added the pr-linter/exempt-test The PR linter will not require test changes label Aug 3, 2023
@mrgrain
Copy link
Contributor Author

mrgrain commented Aug 3, 2023

Added exemptions as existing tests provide coverage.

@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Aug 3, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 3, 2023 07:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain mrgrain self-assigned this Aug 3, 2023
@mrgrain mrgrain requested a review from rix0rrr August 3, 2023 16:36
@mrgrain mrgrain marked this pull request as ready for review August 3, 2023 18:52
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4c02b96
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 54e64c7 into main Aug 3, 2023
8 checks passed
@mergify mergify bot deleted the mrgrain/fix/log-retention-v3 branch August 3, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants