Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): Lambda Insights Layer ARN 1.0.229 in us-west-1 on ARM64 incorrect #26626

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

khushail
Copy link
Contributor

@khushail khushail commented Aug 3, 2023

Existing documentation

Closes #26615 .


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Aug 3, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 3, 2023 20:01
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@khushail khushail changed the title Lambda Insights has incorrect ARN for 1.0.229 in us-west-1 on ARM64 Lambda Insights: corrected ARN for 1.0.229 in us-west-1 on ARM64 Aug 3, 2023
@khushail khushail changed the title Lambda Insights: corrected ARN for 1.0.229 in us-west-1 on ARM64 fix(lambda): updated ARN for 1.0.229 in us-west-1 on ARM64 Aug 3, 2023
@khushail khushail marked this pull request as ready for review August 3, 2023 20:17
@rix0rrr rix0rrr changed the title fix(lambda): updated ARN for 1.0.229 in us-west-1 on ARM64 fix(lambda): Lambda Insights Layer ARN for 1.0.229 in us-west-1 on ARM64 incorrect Aug 4, 2023
@rix0rrr rix0rrr changed the title fix(lambda): Lambda Insights Layer ARN for 1.0.229 in us-west-1 on ARM64 incorrect fix(lambda): Lambda Insights Layer ARN 1.0.229 in us-west-1 on ARM64 incorrect Aug 4, 2023
@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Aug 4, 2023
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 4, 2023

You'll still need to fix the build...

@aws-cdk-automation aws-cdk-automation dismissed their stale review August 4, 2023 07:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 4, 2023
@khushail
Copy link
Contributor Author

khushail commented Aug 4, 2023

You'll still need to fix the build...

fixed.

@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 7, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 98c043b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit dabf868 into main Aug 7, 2023
11 checks passed
@mergify mergify bot deleted the khushail/ARNCorrection branch August 7, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda Insights has incorrect ARN for 1.0.229 in us-west-1 on ARM64
3 participants