Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken cross-region reference in aws-route53 #26666

Merged
merged 7 commits into from
Aug 8, 2023
Merged

fix: broken cross-region reference in aws-route53 #26666

merged 7 commits into from
Aug 8, 2023

Conversation

MrArnoldPalmer
Copy link
Contributor

Fixes the cross region zone delegation custom resource in route53 by
reverting to using the v2 aws-sdk. This requires reverting the runtime
to use Node16 until we figure out the correct usage of the v3 sdk.

At this point I suspect it is an issue with the SDK but I have been
unable to reliably reproduce the bug, regardless of the parent or child
stack being in an opt-in region and vice versa

Fixes: #26593


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fixes the cross region zone delegation custom resource in route53 by
reverting to using the v2 aws-sdk. This requires reverting the runtime
to use Node16 until we figure out the correct usage of the v3 sdk.

At this point I suspect it is an issue with the SDK but I have been
unable to reliably reproduce the bug, regardless of the parent or child
stack being in an opt-in region and vice versa

Fixes: #26593
@github-actions github-actions bot added the p2 label Aug 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 8, 2023 02:39
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 8, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@MrArnoldPalmer MrArnoldPalmer added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Aug 8, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 8, 2023 02:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 86fa325
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ec61b09 into main Aug 8, 2023
8 checks passed
@mergify mergify bot deleted the fix/26593 branch August 8, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route53’s CrossAccountZoneDelegationRecord is broken in v2.87+ for opt-in region to non-opt-in region
3 participants