Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ec2): add M7gd, R7gd, C7gd instance types #26776

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

funguy-tech
Copy link
Contributor

@funguy-tech funguy-tech commented Aug 16, 2023

As of v2.92.0, we don't yet have C7gd, M7gd, and R7gd instance types available via instance type selection.

Closes #26774


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Aug 16, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 16, 2023 14:43
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@funguy-tech funguy-tech force-pushed the add-graviton-7-nvme branch 2 times, most recently from 136e4dd to 98f39b9 Compare August 16, 2023 15:03
@funguy-tech funguy-tech changed the title (ec2): add metadata for M7gd, R7gd, C7gd instance types feat(ec2): add metadata for M7gd, R7gd, C7gd instance types Aug 16, 2023
The instance type enum and map currently exclude the x7GD subfamily of instance types.
@funguy-tech
Copy link
Contributor Author

funguy-tech commented Aug 16, 2023

Clarification Request. Current documentation / integration tests do not seem to specifically test the 'd' subfamily of instance types. A codebase search for '6gd' shows only documentation related to ElasticSearch and ElastiCache, which should be updated when the respective services update to support this instance type instead of when the instance types become selectable for general EC2 provisioning. It is unclear where a README or which Integration Tests would be updated to reflect availability of these new instance types.

Should this be categorized as something other than feat, or just subject to a manual review to bypass the automated PR checks since they do not seem to apply fully here?

Modeled after #12301

@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 16, 2023
@colifran colifran changed the title feat(ec2): add metadata for M7gd, R7gd, C7gd instance types chore(ec2): add M7gd, R7gd, C7gd instance types Aug 17, 2023
@colifran
Copy link
Contributor

@funguy-tech Thanks for working on this. I updated the title to be a chore. I found a similar PR (#24450) that we can model this after. That said, we don't need an integ test or a README update for this.

@aws-cdk-automation aws-cdk-automation dismissed their stale review August 17, 2023 23:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Aug 17, 2023
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@funguy-tech Looks good. Thanks for adding these!

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 18, 2023
@mergify mergify bot merged commit 728af19 into aws:main Aug 18, 2023
11 checks passed
@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 399125e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ec2): add metadata for M7gd, R7gd, C7gd instance types
3 participants