Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): support for r7i instance type in aws-ec2 #27737

Merged
merged 15 commits into from
Nov 9, 2023
Merged

feat(ec2): support for r7i instance type in aws-ec2 #27737

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a72ec34
add r7i option to ec2 instance types
kevntao Oct 27, 2023
26f98b7
Merge branch 'main' into kevntao/ec2-r7i
kevntao Oct 30, 2023
a06c984
Merge branch 'main' into kevntao/ec2-r7i
kevntao Oct 30, 2023
13ce290
Merge branch 'main' into kevntao/ec2-r7i
kevntao Nov 1, 2023
3afe9a3
Merge branch 'main' into kevntao/ec2-r7i
kevntao Nov 2, 2023
5219fcd
Merge branch 'main' into kevntao/ec2-r7i
kevntao Nov 6, 2023
29a9cbd
switch r7i to MEMORY7_INTEL_BASE
kevntao Nov 6, 2023
0d7c6f5
Merge branch 'main' into kevntao/ec2-r7i
kevntao Nov 6, 2023
c741408
Merge branch 'main' into kevntao/ec2-r7i
kevntao Nov 7, 2023
4231c0c
Merge branch 'main' into kevntao/ec2-r7i
kevntao Nov 7, 2023
6afaba6
Merge branch 'main' into kevntao/ec2-r7i
kevntao Nov 7, 2023
f9473ee
Merge branch 'main' into kevntao/ec2-r7i
kevntao Nov 8, 2023
5752fc8
Merge branch 'main' into kevntao/ec2-r7i
kevntao Nov 9, 2023
38d9458
Update packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts
scanlonp Nov 9, 2023
25906bb
Update packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts
scanlonp Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,11 @@ export enum InstanceClass {
*/
R7GD = 'r7gd',

/**
* Memory optimized instances based on Intel Xeon Scalable (Sapphire Rapids) processors, 7th generation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets change this to not be the same as r7iz. Or if the better change would be to that doc string, do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree, i had difficulty finding the nuanced difference between the r7i and r7iz, unfortunately you're correct, the MEMORY7_INTEL should have gone to the r7i instead of the r7iz, but I had thought the r7iz was the replacement for the r7i since it used the same processor generation as the c7i and m7i.

I'm totally open to suggestions, but happy to take a stab at it for community review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that mistake is on me. Do what you think looks good and we can go from there!

*/
R7I = 'r7i',

/**
* Memory optimized instances based on Intel Xeon Scalable (Sapphire Rapids) processors, 7th generation
*/
Expand Down Expand Up @@ -1251,6 +1256,7 @@ export class InstanceType {
[InstanceClass.R7G]: 'r7g',
[InstanceClass.MEMORY7_GRAVITON3_NVME_DRIVE]: 'r7gd',
[InstanceClass.R7GD]: 'r7gd',
[InstanceClass.R7I]: 'r7i',
[InstanceClass.MEMORY7_INTEL]: 'r7iz',
[InstanceClass.R7IZ]: 'r7iz',
[InstanceClass.COMPUTE3]: 'c3',
Expand Down
Loading