-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ses): create unit tests for drop spam handler #27769
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
135 changes: 135 additions & 0 deletions
135
packages/aws-cdk-lib/aws-ses/test/drop-spam-handler/drop-spam-handler.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
import { handler } from '../../lib/drop-spam-handler/index'; | ||
|
||
describe('handler', () => { | ||
test('drop spam when spf verdict status is FAIL', async () => { | ||
const sesEvent = createSesEvent({ spf: { status: 'FAIL' } }); | ||
const response = await handler(sesEvent); | ||
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | ||
}); | ||
|
||
test('drop spam when dkim verdict status is FAIL', async () => { | ||
const sesEvent = createSesEvent({ dkim: { status: 'FAIL' } }); | ||
const response = await handler(sesEvent); | ||
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | ||
}); | ||
|
||
test('drop spam when spam verdict status is FAIL', async () => { | ||
const sesEvent = createSesEvent({ spam: { status: 'FAIL' } }); | ||
const response = await handler(sesEvent); | ||
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | ||
}); | ||
|
||
test('drop spam when virus verdict status is FAIL', async () => { | ||
const sesEvent = createSesEvent({ virus: { status: 'FAIL' } }); | ||
const response = await handler(sesEvent); | ||
expect(response).toEqual({ disposition: 'STOP_RULE_SET' }); | ||
}); | ||
|
||
test('all spam checks pass', async () => { | ||
const sesEvent = createSesEvent(); | ||
const response = await handler(sesEvent); | ||
expect(response).toBe(null); | ||
}); | ||
}); | ||
|
||
interface Verdicts { | ||
spam?: AWSLambda.SESReceiptStatus, | ||
virus?: AWSLambda.SESReceiptStatus, | ||
spf?: AWSLambda.SESReceiptStatus, | ||
dkim?: AWSLambda.SESReceiptStatus, | ||
dmarc?: AWSLambda.SESReceiptStatus, | ||
} | ||
|
||
function createSesEvent(verdicts: Verdicts = {}) { | ||
return { | ||
Records: [{ | ||
eventSource: 'aws:sns', | ||
eventVersion: '1.0', | ||
ses: { | ||
mail: { | ||
timestamp: '2023-10-30T20:32:33.936Z', | ||
source: '61967230-7A45-4A9D-BEC9-87CBCF2211C9@example.com', | ||
messageId: 'd6iitobk75ur44p8kdnnp7g2n800', | ||
destination: ['recipient@example.com'], | ||
headersTruncated: false, | ||
headers: [ | ||
{ | ||
name: 'Return-Path', | ||
value: '<0000014fbe1c09cf-7cb9f704-7531-4e53-89a1-5fa9744f5eb6-000000@amazonses.com>', | ||
}, | ||
{ | ||
name: 'Received', | ||
value: 'from a9-183.smtp-out.amazonses.com (a9-183.smtp-out.amazonses.com [54.240.9.183]) by inbound-smtp.us-east-1.amazonaws.com with SMTP id d6iitobk75ur44p8kdnnp7g2n800 for recipient@example.com; Mon, 30 Oct 2023 20:32:33 +0000 (UTC)', | ||
}, | ||
{ | ||
name: 'DKIM-Signature', | ||
value: 'v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug; d=amazonses.com; t=1442003552; h=From:To:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Date:Message-ID:Feedback-ID; bh=DWr3IOmYWoXCA9ARqGC/UaODfghffiwFNRIb2Mckyt4=; b=p4ukUDSFqhqiub+zPR0DW1kp7oJZakrzupr6LBe6sUuvqpBkig56UzUwc29rFbJF hlX3Ov7DeYVNoN38stqwsF8ivcajXpQsXRC1cW9z8x875J041rClAjV7EGbLmudVpPX 4hHst1XPyX5wmgdHIhmUuh8oZKpVqGi6bHGzzf7g=', | ||
}, | ||
{ | ||
name: 'From', | ||
value: 'sender@example.com', | ||
}, | ||
{ | ||
name: 'To', | ||
value: 'recipient@example.com', | ||
}, | ||
{ | ||
name: 'Subject', | ||
value: 'Example subject', | ||
}, | ||
{ | ||
name: 'MIME-Version', | ||
value: '1.0', | ||
}, | ||
{ | ||
name: 'Content-Type', | ||
value: 'text/plain; charset=UTF-8', | ||
}, | ||
{ | ||
name: 'Content-Transfer-Encoding', | ||
value: '7bit', | ||
}, | ||
{ | ||
name: 'Date', | ||
value: 'Mon, 30 Oct 2023 20:32:32 +0000', | ||
}, | ||
{ | ||
name: 'Message-ID', | ||
value: '<61967230-7A45-4A9D-BEC9-87CBCF2211C9@example.com>', | ||
}, | ||
{ | ||
name: 'X-SES-Outgoing', | ||
value: '2023.10.30-54.240.9.183', | ||
}, | ||
{ | ||
name: 'Feedback-ID', | ||
value: '1.us-east-1.Krv2FKpFdWV+KUYw3Qd6wcpPJ4Sv/pOPpEPSHn2u2o4=:AmazonSES', | ||
}, | ||
], | ||
commonHeaders: { | ||
returnPath: '0000014fbe1c09cf-7cb9f704-7531-4e53-89a1-5fa9744f5eb6-000000@amazonses.com', | ||
from: ['sender@example.com'], | ||
date: 'Mon, 30 Oct 2023 20:32:32 +0000', | ||
to: ['recipient@example.com'], | ||
messageId: '<61967230-7A45-4A9D-BEC9-87CBCF2211C9@example.com>', | ||
subject: 'Example subject', | ||
}, | ||
}, | ||
receipt: { | ||
timestamp: '2023-10-30T20:32:33.936Z', | ||
processingTimeMillis: 300, | ||
recipients: ['recipient@example.com'], | ||
spamVerdict: verdicts.spam ?? { status: 'PASS' }, | ||
virusVerdict: verdicts.virus ?? { status: 'PASS' }, | ||
spfVerdict: verdicts.spf ?? { status: 'PASS' }, | ||
dkimVerdict: verdicts.dkim ?? { status: 'PASS' }, | ||
dmarcVerdict: verdicts.dmarc ?? { status: 'PASS' }, | ||
action: { | ||
type: 'SNS', | ||
topicArn: 'arn:aws:sns:us-east-1:012345678912:example-topic', | ||
}, | ||
}, | ||
}, | ||
}], | ||
} as unknown as AWSLambda.SESEvent; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nitpicking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Updated.