fix(ecs): empty placement constraints not allowed #28595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Currently blocked by an out of sync ECS state preventing me from running the necessary integ tests. Have cut a ticket but will close this for the time being in case anyone else wishes to work on this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
omitEmptyArrayfrom ec2 constructor to support removing all existing placement constraints.This PR does not address supporting empty placement strategies because of the following reason: #27572 (comment)
More investigation is required for how to address empty placement strategies.
Addresses the empty placement constraints half of #27555.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license