Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-resources): cannot set logging for state machine generated in CompleteHandler #28706

Merged
merged 51 commits into from
Apr 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
9ced5e8
add implementation without integ tests and index.ts
go-to-k Jan 14, 2024
8b5b49f
index.ts
go-to-k Jan 14, 2024
dcc4dc3
integ tests for dynamodb
go-to-k Jan 14, 2024
49ebbee
add integ for custom-resources/test/provider-framework/integ.provider
go-to-k Jan 14, 2024
3f978f6
aws-rds/test/integ.cluster-snapshot
go-to-k Jan 14, 2024
36a7cf5
framework-integ/test/aws-eks/test/integ.alb-controller.js.snapshot
go-to-k Jan 14, 2024
99fa1bd
aws-stepfunctions-tasks/test/emrcontainers/integ.job-submission-workflow
go-to-k Jan 14, 2024
6cee88b
aws-stepfunctions-tasks/test/emrcontainers/integ.start-job-run-aws-st…
go-to-k Jan 14, 2024
90ec02f
test/integ.eks-cluster-imported
go-to-k Jan 14, 2024
aaef07d
integ.eks-cluster-ipv6
go-to-k Jan 14, 2024
6d3a998
aws-eks/test/integ.eks-cluster-private-endpoint
go-to-k Jan 14, 2024
90d32e5
integ.eks-cluster.js.snapshot
go-to-k Jan 14, 2024
f550c6a
test/integ.eks-helm-asset
go-to-k Jan 14, 2024
472f8ab
integ.eks-inference-nodegroup
go-to-k Jan 14, 2024
de4029e
other snapshots
go-to-k Jan 14, 2024
eeb6197
integ.provider-with-waiter-state-machine
go-to-k Jan 14, 2024
a2c242e
aws-amplify-alpha/test/integ.app-asset-deployment
go-to-k Jan 14, 2024
71f1a7e
change package-lock.json
go-to-k Jan 14, 2024
99bb440
integ.cluster-snapshot.js.snapshot
go-to-k Jan 14, 2024
64ae3a9
rest snapshots
go-to-k Jan 14, 2024
fe3d1e0
docs
go-to-k Jan 14, 2024
a0820e6
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into sfn-lo…
go-to-k Jan 18, 2024
61eeb14
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into sfn-lo…
go-to-k Jan 20, 2024
9ca8951
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into sfn-lo…
go-to-k Jan 31, 2024
cd05ed1
change snapshots
go-to-k Jan 31, 2024
43d1d9d
Merge branch 'main' into sfn-log-provider
go-to-k Jan 31, 2024
fc5c8cb
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into sfn-lo…
go-to-k Feb 6, 2024
19a646d
change snapshots
go-to-k Feb 6, 2024
bbefd54
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into sfn-lo…
go-to-k Feb 27, 2024
e4f5693
integ in aws-amplify-alpha
go-to-k Feb 27, 2024
0c788f0
custom-resources
go-to-k Feb 27, 2024
2aa2515
aws-dynamodb
go-to-k Feb 27, 2024
fcfb30c
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into sfn-lo…
go-to-k Mar 11, 2024
9813034
aws-amplify-alpha/test/integ.app-asset-deployment
go-to-k Mar 11, 2024
abd45b2
framework-integ/test/aws-dynamodb
go-to-k Mar 11, 2024
4747d9d
aws-dynamodb snapshots
go-to-k Mar 11, 2024
68d5462
custom-resources snapshot
go-to-k Mar 11, 2024
3ffc464
aws-dynamodb
go-to-k Mar 11, 2024
7ae9cfb
aws-amplify-alpha
go-to-k Mar 11, 2024
da1d31b
custom-resources
go-to-k Mar 11, 2024
76b34e6
Merge branch 'main' into sfn-log-provider
go-to-k Mar 13, 2024
522644d
Merge branch 'main' into sfn-log-provider
go-to-k Apr 9, 2024
b3895e9
aws-eks/test/integ.eks-al2023-nodegroup
go-to-k Apr 9, 2024
d729180
Merge branch 'main' of https://github.com/go-to-k/aws-cdk into sfn-lo…
go-to-k Apr 17, 2024
8d48434
Merge branch 'main' into sfn-log-provider
go-to-k Apr 17, 2024
34136f3
add a new line
go-to-k Apr 18, 2024
d9a67ae
add a new line in tests
go-to-k Apr 18, 2024
81d420a
Merge branch 'main' into sfn-log-provider
paulhcsun Apr 18, 2024
3998877
Merge branch 'main' into sfn-log-provider
mergify[bot] Apr 18, 2024
18db57a
Merge branch 'main' into sfn-log-provider
mergify[bot] Apr 19, 2024
5621cbb
Merge branch 'main' into sfn-log-provider
mergify[bot] Apr 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@
{
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"/9e74695d20fbb89dc62fd8a020b6273050655fc292429f61f3ec014282a93e69.json"
"/960077579d48da3054d2f2b5a09cca17fc80809a34ba0d9d2d2fd19702c9b684.json"
]
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,22 @@
]
}
]
},
{
"Action": [
"logs:CreateLogDelivery",
"logs:CreateLogStream",
"logs:DeleteLogDelivery",
"logs:DescribeLogGroups",
"logs:DescribeResourcePolicies",
"logs:GetLogDelivery",
"logs:ListLogDeliveries",
"logs:PutLogEvents",
"logs:PutResourcePolicy",
"logs:UpdateLogDelivery"
],
"Effect": "Allow",
"Resource": "*"
}
],
"Version": "2012-10-17"
Expand All @@ -688,6 +704,26 @@
]
}
},
"ProviderwaiterstatemachineLogGroupDD693A98": {
"Type": "AWS::Logs::LogGroup",
"Properties": {
"LogGroupName": {
"Fn::Join": [
"",
[
"/aws/vendedlogs/states/waiter-state-machine-",
{
"Ref": "ProviderframeworkisComplete26D7B0CB"
},
"-c861cd2a83a6af30e2613fcc9324bc4db65ca58d7f"
]
]
},
"RetentionInDays": 731
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
},
"Providerwaiterstatemachine5D4A9DF0": {
"Type": "AWS::StepFunctions::StateMachine",
"Properties": {
Expand All @@ -713,6 +749,22 @@
]
]
},
"LoggingConfiguration": {
"Destinations": [
{
"CloudWatchLogsLogGroup": {
"LogGroupArn": {
"Fn::GetAtt": [
"ProviderwaiterstatemachineLogGroupDD693A98",
"Arn"
]
}
}
}
],
"IncludeExecutionData": false,
"Level": "ERROR"
},
"RoleArn": {
"Fn::GetAtt": [
"ProviderwaiterstatemachineRole0C7159F9",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@
{
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-eu-west-1"
},
"/4148c9473bcbd8c19e338a215d442b27cc755081d5d4980c0648dfd92306e0e5.json"
"/8b3c6feb070f454632cee6e863c7ec94af3254d0071ad904533703d3b66a63b8.json"
]
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,22 @@
]
}
]
},
{
"Action": [
"logs:CreateLogDelivery",
"logs:CreateLogStream",
"logs:DeleteLogDelivery",
"logs:DescribeLogGroups",
"logs:DescribeResourcePolicies",
"logs:GetLogDelivery",
"logs:ListLogDeliveries",
"logs:PutLogEvents",
"logs:PutResourcePolicy",
"logs:UpdateLogDelivery"
],
"Effect": "Allow",
"Resource": "*"
}
],
"Version": "2012-10-17"
Expand All @@ -684,6 +700,26 @@
]
}
},
"ProviderwaiterstatemachineLogGroupDD693A98": {
"Type": "AWS::Logs::LogGroup",
"Properties": {
"LogGroupName": {
"Fn::Join": [
"",
[
"/aws/vendedlogs/states/waiter-state-machine-",
{
"Ref": "ProviderframeworkisComplete26D7B0CB"
},
"-c8696e1868b3a8bafc51799993fdba7f11ffdcc5c5"
]
]
},
"RetentionInDays": 731
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
},
"Providerwaiterstatemachine5D4A9DF0": {
"Type": "AWS::StepFunctions::StateMachine",
"Properties": {
Expand All @@ -709,6 +745,22 @@
]
]
},
"LoggingConfiguration": {
"Destinations": [
{
"CloudWatchLogsLogGroup": {
"LogGroupArn": {
"Fn::GetAtt": [
"ProviderwaiterstatemachineLogGroupDD693A98",
"Arn"
]
}
}
}
],
"IncludeExecutionData": false,
"Level": "ERROR"
},
"RoleArn": {
"Fn::GetAtt": [
"ProviderwaiterstatemachineRole0C7159F9",
Expand Down
Loading