Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): cdk watch for Lambdas with Advanced Logging Controls do not stream logs to the terminal #29451
fix(cli): cdk watch for Lambdas with Advanced Logging Controls do not stream logs to the terminal #29451
Changes from 2 commits
589e2d8
567adf5
d62dd4b
49089d0
ce4a051
398732b
dcc39a0
f8bcdfc
1acf29d
6dc6827
95f7904
c22a3a2
b51b6fe
1d8d8a5
5cebbcf
e3f49b7
1d9bf61
0abae7e
802e1db
0fe76ca
cad211c
48a9b05
77105bd
28c6ecf
ae37db2
750aa2b
f5794c0
1b35bbf
5761504
830ee9c
33a37e9
32981b2
f941cde
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lambda is not the only service that creates custom
logGroupName
s. We should note that similar functionality may be needed for several other services (rds, neptune, docdb, etc). However, Lambda Function was the only resource inRESOURCE_TYPES_WITH_IMPLICIT_LOGS
, so we definitely do not need to add that functionality.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though about that while making this change but as the only reference I had was the Lambda one I thought in not adding more stuff than the things that already exists, but I can definitely work on that extras on upcoming PRs now that I got familiarity with the codebase.