Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): add v7 VPC flow log record fields #30229

Closed
wants to merge 1 commit into from

Conversation

gricey432
Copy link

Reason for this change

AWS recently added new ECS-focused fields to the VPC flow logs.

Description of changes

Update CDK's list of fields to include the new fields.

I've just followed the pattern that was there.

Description of how you validated changes

Extended the existing tests. Though I'm unable to run the integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 16, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 16, 2024 04:33
@github-actions github-actions bot added the p2 label May 16, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@gricey432
Copy link
Author

Exemption Request

  • There is already a README section covering this, new values don't require a change
  • I'm unable to run the integration tests

@gricey432 gricey432 changed the title fix(ec2): Add v7 VPC flow log record fields fix(ec2): add v7 VPC flow log record fields May 16, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9412881
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@badmintoncryer
Copy link
Contributor

@gricey432 This PR(#30202) has already been submitted.

@gricey432 gricey432 closed this May 16, 2024
@gricey432
Copy link
Author

@gricey432 This PR(#30202) has already been submitted.

Awesome! Looks like it's in much better shape than mine, closing in favour

@badmintoncryer
Copy link
Contributor

Thanks! We look forward to another PR!

@gricey432
Copy link
Author

@badmintoncryer what's happening with the process here? That other PR has been waiting on a review for over a month. Is there anything I can be doing to assist with the process of getting this change in in some form?

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Jun 22, 2024

@gricey432 It seems to be waiting for community review. This process may take several months, because it is unclear when the reviewers will look at it😓 So please be patient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants