feat(cli): add ability to configure hotswap properties for ECS

[atanaspam]

Issue #29618

Reason for this change

We aim to speed up deployment times in our development environment by using the hotswap feature. However, our services have dependencies on each other, and the current hotswap behavior is too disruptive.

Description of changes

We modified the hotswap implementation for ECS services to pass the minimumHealthyPercent and maximumHealthyPercent configurable parameters. These parameters are exposed to the cli and can be passed as --hotswap-ecs-minimum-healthy-percent <number> and --hotswap-ecs-maximum-healthy-percent <number>

The implementation is careful to maintain the existing behaviour. That is, if none of the new flags is used, the current minimumHealthyPercent = 0 and maximumHealthyPercent = undefined values are used.

Description of how you validated changes

We added a unit test validating that the correct values are passed to the task definition. We also executed using the locally built version of cdk validating that the behavior is as expected: the parameters are respected during hotswap deployments, and the existing API is maintained.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[atanaspam]

Clarification Request

❌ Features must contain a change to an integration test file and the resulting snapshot.

I was able to execute the integration tests I added locally successfully, but there doesn't seem to be any snapshot changes for me to report.

[ahammond]

This would have made it easier / more likely for us to stay on ECS instead of moving to EKS.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[atanaspam]

Hey folks, can I have a review here please? I'd love to merge this soon as it has been hanging around for a while

[comcalvi]

Sorry for the delay on this one, this is a great change!

It's unfortunate that we chose to put the entire SDK call into the promises array, and not separated out the arguments...that would've prevented us from passing this thing throughout the entire code path, but it's fine as-is.

Minor comments only.

[comcalvi]

Suggested change

	export class HotswapProperties {
	export class HotswapPropertyOverrides {

[atanaspam]

I have renamed the class and also all the variables as we propagate the properties throughout the code path to reflect the new name.

[aws-cdk-automation]

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[atanaspam]

@comcalvi @kaizencc I had to update the PR as mergify failed to merge this automatically due to what I assume is an incoming change.
https://github.com/aws/aws-cdk/pull/30511/checks?check_run_id=31046011303

Can you please review again?

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 34bd7ff
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository