feat(redshift): supports excludeCharacters settings for DatabaseSecret #30563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
star-contributor
aws-cdk-automation
added
the
pr/needs-community-review
badmintoncryer
approved these changes
Sep 23, 2024
| testCases: [new RedshiftEnv(app, 'redshift-exclude-characters-integ')], | ||
| }); | ||
|
|
||
| app.synth(); |
There was a problem hiding this comment.
nit: it is not essential
Suggested change
| app.synth(); |
There was a problem hiding this comment.
Thanks.
I've removed.
aws-cdk-automation
added
pr/needs-maintainer-review
sumupitchayan
approved these changes
Sep 26, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #26847.
Reason for this change
In the case of passwords generated by DatabaseSecret, there may be a need to exclude certain characters.
The original issue was to exclude the backtick character from passwords.
However, the current default value of
excludeCharacters,'"@/\ '', matches the characters that are not supported in Redshift (docs).Instead of including the backtick in the default value of
excludeCharacters, it was considered appropriate to make it configurable.Description of changes
Add
excludeCharactersproperty to specify characters to not include in generated passwords.Description of how you validated changes
Add unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license