feat(apprunner): support vpc ingress connection #30623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
star-contributor
mazyu36
force-pushed
the
apprunner-private-access-22850
branch
from
5b3e3e1
to
6e66ff9
Compare
|
@Mergifyio update |
☑️ Nothing to do
|
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
suggested changes
Jul 31, 2024
|
|
||
| public constructor(scope: Construct, id: string, props: VpcIngressConnectionProps) { | ||
| super(scope, id, { | ||
| physicalName: props.vpcIngressConnectionName, |
There was a problem hiding this comment.
Did you check if it deploys with vpcIngressConnectionName: undefined?
If not, we should lazily generate one.
There was a problem hiding this comment.
Thank you. I tried deploying with vpcIngressConnectionName: undefined, and I was able to deploy without any issues.
aws-cdk-automation
removed
the
pr/needs-community-review
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
|
@lpizzinidev |
aws-cdk-automation
added
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #22850.
Reason for this change
To support VPC Ingress Connection for making App Runner Service private and only accessible from within a VPC.
Description of changes
isPubliclyAccessibleproperty to theServiceclassVpcIngressConnectionclassDescription of how you validated changes
Add unit tests and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license