Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lambda-nodejs): breaking change in esbuild causes import module error #30726

Merged
merged 8 commits into from
Jul 1, 2024
Merged

fix(lambda-nodejs): breaking change in esbuild causes import module error #30726

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
def2f9a
fix(aws-lambda-nodejs): pin the esbuild minor version
xazhao Jul 1, 2024
fa9476c
Update packages/aws-cdk-lib/aws-lambda-nodejs/lib/Dockerfile
xazhao Jul 1, 2024
bb3aa8b
update version in bundling as well
TheRealAmazonKendra Jul 1, 2024
2f44737
fix the unit test
xazhao Jul 1, 2024
676acf9
only change the default, not the error messages
TheRealAmazonKendra Jul 1, 2024
96edd3a
Merge branch 'esbuild-fix' of https://github.com/xazhao/aws-cdk into …
TheRealAmazonKendra Jul 1, 2024
6d9a219
Revert "fix the unit test"
TheRealAmazonKendra Jul 1, 2024
bce1753
update integ tests
TheRealAmazonKendra Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-cdk-lib/aws-lambda-nodejs/lib/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ RUN npm install --global typescript

# Install esbuild
# (unsafe-perm because esbuild has a postinstall script)
ARG ESBUILD_VERSION=0
# pin the minor version to 0.21 to prevert breaking change
xazhao marked this conversation as resolved.
Show resolved Hide resolved
ARG ESBUILD_VERSION=0.21
RUN npm install --global --unsafe-perm=true esbuild@$ESBUILD_VERSION

# Ensure all users can write to npm cache
Expand Down
Loading