feat(synthetics): syn-nodejs-puppeteer-9.0 as supported runtime #31272
Conversation
github-actions
bot
added
feature-request
aws-cdk-automation
added
the
pr/needs-maintainer-review
| * - Chromium version 126.0.6478.126 | ||
| * | ||
| * New Features: | ||
| * - **Bug fixes** Bug fix to enable visual monitoring capabilities. |
There was a problem hiding this comment.
Nit:
* Bug fixes:
* - **Bug fix**: Enable visual monitoring capabilities.
There was a problem hiding this comment.
@msambol Thanks for the review. I copied the content from https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-9.0.
There was a problem hiding this comment.
right, I'm just saying it shouldn't be under New Features:
There was a problem hiding this comment.
I think this is fine -- its a little weird but we've already established a pattern of bug fixes being listed as a bullet under new features.
kaizencc
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
github-actions
bot
added
the
effort/small
kaizencc
added
pr-linter/exempt-test
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
kaizencc
added
the
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
deleted the
user/ashdhin/add-syn-nodejs-puppeteer-9.0-runtime
branch
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31271.
Reason for this change
Runtime versions using Node.js and Puppeteer confirms that Synthetics runtime
syn-nodejs-puppeteer-9.0is available.Description of changes
Added
syn-nodejs-puppeteer-9.0as supported runtime.Description of how you validated changes
N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license