Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update s3 bucket physical names to use amazon owned s3 buckets #31576

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

evzzk
Copy link
Contributor

@evzzk evzzk commented Sep 26, 2024

Issue # (if applicable)

Closes #.

Reason for this change

By using Amazon owned s3 bucket physical names, we remove the possibility of documenting customer owned buckets in our examples.

Description of changes

Change physical S3 bucket names such as my-bucket to Amazon owned ones such as amzn-s3-demo-bucket.

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 26, 2024 16:56
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 26, 2024
rix0rrr
rix0rrr previously approved these changes Sep 26, 2024
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get the build to succeed you are going to need to run some of the integ tests. you should be able to add --dry-run to the integ command so that you don't actually deploy the test

@mergify mergify bot dismissed rix0rrr’s stale review October 4, 2024 23:54

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b9b3305
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants