fix(rds): fixed the IAM policy that grantConnect() generates for DatabaseInstanceReadReplica #31579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…baseInstanceReadReplica
…ceResourceIdV2 property in DatabaseInstanceReadReplica to use in grantConnect().
…InstanceReadReplica-GrantRead-Fix # Conflicts: # packages/@aws-cdk/cx-api/FEATURE_FLAGS.md # packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md # packages/aws-cdk-lib/cx-api/README.md # packages/aws-cdk-lib/cx-api/lib/features.ts # packages/aws-cdk-lib/cx-api/test/features.test.ts
…InstanceReadReplica-GrantRead-Fix # Conflicts: # packages/@aws-cdk/cx-api/FEATURE_FLAGS.md # packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md # packages/aws-cdk-lib/cx-api/README.md # packages/aws-cdk-lib/cx-api/lib/features.ts
github-actions
bot
added
bug
Closed
1 task
paulhcsun
reviewed
Sep 26, 2024
paulhcsun
reviewed
Sep 26, 2024
| When this feature flag is enabled, the value of that property will be as expected set to 'DbiResourceId' attribute, and that will fix the grantConnect method. | ||
| `, | ||
| introducedIn: { v2: 'V2NEXT' }, | ||
| defaults: { v2: false }, |
There was a problem hiding this comment.
I don't think this line is needed. It's only required if you need to set the default to true, otherwise it should be false automatically.
paulhcsun
approved these changes
Sep 26, 2024
|
@Mergifyio update |
☑️ Nothing to do
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
deleted the
ashishdhingra/DatabaseInstanceReadReplica-GrantRead-Fix
branch
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31061.
Reason for this change
Calling
grantConnect()on an instance ofDatabaseInstanceReadReplicagenerates an incorrect policy that uses the full ARN of the instance instead of the instanceResourceId value. It should have created policy with correct resource formatarn:aws:rds-db:region:account-id:dbuser:DbiResourceId/db-user-nameper Creating and using an IAM policy for IAM database access.Description of changes
Fixed the IAM policy that
grantConnect()generates forDatabaseInstanceReadReplica. The change correctly sets the value ofinstanceResourceIdto replica instanceattrDbiResourceId. The value ofinstanceResourceIdis used to generate IAM policy.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license