Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): expose authorizer id and authorization type #31622

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JonWallsten
Copy link

@JonWallsten JonWallsten commented Oct 2, 2024

Issue # (if applicable)

Closes #31605.

Reason for this change

I need to access the authorizer id and type to be able to import the authorizer in another CDK project

Description of changes

I have added a public readonly variable for the authorizationType that was previously a string in the return object from the bind function.
I have also added a getter that will return the authorizerId after the first binding. If not bound yet it will throw an error.

Description of how you validated changes

I have added unit tests for all changed files.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 2, 2024 14:01
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 2, 2024
@JonWallsten
Copy link
Author

@pahud

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pahud
Copy link
Contributor

pahud commented Oct 2, 2024

Thank you for your PR.

This PR will need at least one community review/approval before the flow can bump it to pending for maintainer review queue.

Please check CDK Community Reviews for more details
https://github.com/aws/aws-cdk/wiki/CDK-Community-PR-Reviews

@JonWallsten
Copy link
Author

JonWallsten commented Oct 3, 2024

Edit: Contributing to AWS CDK using Windows is a horrible experience. Switched to Mac.

@JonWallsten JonWallsten changed the title feat(cdk): Exposes authorizer id and authorization type feat(cdk):exposes authorizer id and authorization type Oct 3, 2024
@JonWallsten JonWallsten changed the title feat(cdk):exposes authorizer id and authorization type feat(cdk): expose authorizer id and authorization type Oct 4, 2024
@pahud
Copy link
Contributor

pahud commented Oct 4, 2024

@JonWallsten My personal favorite is CodeCatalyst DevEnv.

You may find this article helpful FYI
https://community.aws/content/2jhmIXdVWZJy3uJnUfEzEmp652j/contributing-to-aws-cdk

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 19251e7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-apigatewayv2-authorizers): Expose Authorizer ID to make it reusable from other projects
3 participants