-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk): expose authorizer id and authorization type #31622
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Thank you for your PR. This PR will need at least one community review/approval before the flow can bump it to pending for maintainer review queue. Please check CDK Community Reviews for more details |
Edit: Contributing to AWS CDK using Windows is a horrible experience. Switched to Mac. |
ef489a3
to
f0f94fd
Compare
f0f94fd
to
1613fe0
Compare
Added example in README file
e16afd9
to
6b75152
Compare
@JonWallsten My personal favorite is CodeCatalyst DevEnv. You may find this article helpful FYI |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #31605.
Reason for this change
I need to access the authorizer id and type to be able to import the authorizer in another CDK project
Description of changes
I have added a public readonly variable for the authorizationType that was previously a string in the return object from the bind function.
I have also added a getter that will return the authorizerId after the first binding. If not bound yet it will throw an error.
Description of how you validated changes
I have added unit tests for all changed files.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license