Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: restrict allowable types in IAM libraries #629

Merged
merged 3 commits into from
Aug 27, 2018
Merged

BREAKING CHANGE: restrict allowable types in IAM libraries #629

merged 3 commits into from
Aug 27, 2018

Commits on Aug 27, 2018

  1. fix: restrict allowable types in IAM libraries 

    A number methods were allowing 'any's in places where they easily lead
to passing the wrong object.

- `role.attachManagedPolicy`
- Various methods on `PolicyStatement`.

By restrictinig the types to what we actually expect (or `string`s)
these mistakes will be harder to make.

Fixes #622, doesn't completely resolve but helps with #621.
    Rico Huijbers committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    8794552 View commit details
    Browse the repository at this point in the history

  2. BREAKING CHANGE: all places where we call addResource('*') need to be… 

    … fixed
    Rico Huijbers committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    0181933 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into huijbers/more-speci… 

    …fic-iam-types
    Rico Huijbers committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    09b2adb View commit details
    Browse the repository at this point in the history