chore: remove awkward cfn2ts script entries #8231
Conversation
Packages that are not containers of L1 libraries (`Cfn~` classes) have no point in having a `cfn2ts` script registered. This causes problems when trying to generate L1s across the whole repository using `lerna run cfn2ts`. This adds a `pkglint` rule that mandates the `cfn2ts` script is only present when the related other metadata is also required to be present.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| const yarnLock: YarnLock = lockfile.parse(await fs.readFile(yarnLockLoc, { encoding: 'utf-8' })); | ||
| const yarnLock: YarnLock = lockfile.parse(await fs.readFile(yarnLockLoc, { encoding: 'utf8' })); |
There was a problem hiding this comment.
Yuck. Someone missed the ball on strong typing here.
There was a problem hiding this comment.
I think this might be some stuff in @types/node somehow becoming a little stricter than before (possibly due to changes in newer versions of node).
| @@ -41,7 +41,6 @@ | |||
| "pkglint": "pkglint -f", | |||
| "package": "cdk-package", | |||
| "awslint": "cdk-awslint", | |||
| "cfn2ts": "cfn2ts", | |||
There was a problem hiding this comment.
To prevent this from happening in the future, should we have a linter rule that cross-references against 'CloudFormation' key under 'cdk-build' in the package.json?
There was a problem hiding this comment.
Well in fact, the isAWS condition on the rule I modified is that cross-reference against the cdk-build.cloudformation key...
…ess-cfn2ts-script-entries
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Packages that are not containers of L1 libraries (
Cfn~classes) haveno point in having a
cfn2tsscript registered. This causes problemswhen trying to generate L1s across the whole repository using
lerna run cfn2ts.This adds a
pkglintrule that mandates thecfn2tsscript is onlypresent when the related other metadata is also required to be present.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license