[CLIv2] Remove backcompat shim in shorthand parser #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesls
requested review from
dstufft,
stealthycoin,
joguSD,
JordonPhillips and
kyleknap
kyleknap
approved these changes
Sep 19, 2018
Now foo=bar will parse to {'foo': 'bar'}, which resolves
an inconsistency that you can't tell how a shorthand snippet
is parsed without also knowing the underlying types in the service
model.
There were some changes I had to make in the EMR tests, but that
was primarily related to the expected messages in the error cases.
CLIv2: aws#3587
jamesls
force-pushed
the
v2-backcompat-shim
branch
from
ae196cf
to
2744c79
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #3589 +/- ##
=====================================
Coverage ? 94.93%
=====================================
Files ? 180
Lines ? 13677
Branches ? 0
=====================================
Hits ? 12984
Misses ? 693
Partials ? 0
Continue to review full report at Codecov.
|
jamesls
added a commit
that referenced
this pull request
Sep 20, 2018
PR #3589 * v2-backcompat-shim: Update functional tests for ec2 Remove backcompat shim in shorthand parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now foo=bar will parse to {'foo': 'bar'}, which resolves
an inconsistency that you can't tell how a shorthand snippet
is parsed without also knowing the underlying types in the service
model.
There were some changes I had to make in the EMR tests, but that
was primarily related to the expected messages in the error cases.
CLIv2: #3587