fix: pass the missing extra_hosts argument
#6889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/local/start-api
|
Thanks for making creating this fix! The changes look good to me, can you run a quick |
lucashuy
removed
the
stage/needs-triage
|
@lucashuy Thanks for your feedback. I've run |
lucashuy
approved these changes
Apr 5, 2024
|
Thanks for updating the PR, looks like the workflow passes! Just need one more reviewer from our team before we can merge this in. |
mndeveci
approved these changes
Apr 5, 2024
Comment on lines
+70
to
+71
| container_host_interface string | ||
| Optional. Interface that Docker host binds ports to |
There was a problem hiding this comment.
Thanks for updating missing documentation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
This fixes #6888 and related to #6078.
I have confirmed that this change makes
--add-hostwork.Why is this change necessary?
I change to pass the
extra_hoststhat were not passed as arguments.Because
sam local start-api --add-hostdoes not work.How does it address the issue?
Pass the missing argument.
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.