chore: Build bzip2 from source for Linux Pyinstaller builds #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucashuy
commented
Apr 9, 2024
| curl "https://www.openssl.org/source/openssl-${openssl_version}.tar.gz" --output openssl.tar.gz | ||
| tar xzf openssl.tar.gz | ||
| cd openssl-${openssl_version} | ||
| ./config --prefix=/opt/openssl && make -j8 && make -j8 install_sw |
There was a problem hiding this comment.
The install_sw target installs OpenSSL without all the manual pages.
There was a problem hiding this comment.
Actually, let me just add a comment for this in the scripts
mndeveci
reviewed
Apr 10, 2024
installer/pyinstaller/samcli.spec
Outdated
Comment on lines
8
to
9
| ('/usr/local/lib/libbz2.so.1', '.'), | ||
| ('/usr/local/lib/libcrypt.so.2', '.') |
There was a problem hiding this comment.
There was an earlier discussion with @hnnasit about removing this all together. Do we know if it is possible to remove these custom configs just like the MacOS ones?
There was a problem hiding this comment.
Good point, we can try removing both of these to test. We can add them back easily anyways
mndeveci
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
None.
Why is this change necessary?
The version of
bzip2used in the image that builds the Linux Pyinstaller artifacts are old. We need to update them to a newer version.How does it address the issue?
Builds
bzip2from source, consuming the1.0.8version instead of the1.0.6in the image.What side effects does this change have?
None
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.