Skip to content

Commit

Permalink
fixed a typo by renaming AddAsIsPresigingMiddleware to AddAsIsPresign…
Browse files Browse the repository at this point in the history
…ingMiddleware (#2486)
  • Loading branch information
matheusorienrac authored Mar 4, 2024
1 parent 322458b commit 530583e
Show file tree
Hide file tree
Showing 11 changed files with 32 additions and 10 deletions.
8 changes: 8 additions & 0 deletions .changelog/ae10fe5c667445a28a7ef7abcd638af1.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "ae10fe5c-6674-45a2-8a7e-f7abcd638af1",
"type": "bugfix",
"description": "Correct a typo in internal AddAsIsPresigningMiddleware API.",
"modules": [
"service/internal/presigned-url"
]
}
14 changes: 14 additions & 0 deletions .changelog/c865415248e948c485e2ff07013d2236.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"id": "c8654152-48e9-48c4-85e2-ff07013d2236",
"type": "bugfix",
"description": "Update internal/presigned-url dependency for corrected API name.",
"modules": [
"service/docdb",
"service/ec2",
"service/neptune",
"service/polly",
"service/rds",
"service/s3",
"service/sts"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ private void writeConvertToPresignMiddleware(
}

Symbol addAsPresignMiddlewareSymbol = SymbolUtils.createValueSymbolBuilder(
"AddAsIsPresigingMiddleware",
"AddAsIsPresigningMiddleware",
AwsCustomGoDependency.PRESIGNEDURL_CUSTOMIZATION).build();
writer.write("err = $T(stack)", addAsPresignMiddlewareSymbol);
writer.write("if err != nil { return err }");
Expand Down
2 changes: 1 addition & 1 deletion service/docdb/api_client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/ec2/api_client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions service/internal/presigned-url/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ func GetIsPresigning(ctx context.Context) bool {

type isPresigningKey struct{}

// AddAsIsPresigingMiddleware adds a middleware to the head of the stack that
// AddAsIsPresigningMiddleware adds a middleware to the head of the stack that
// will update the stack's context to be flagged as being invoked for the
// purpose of presigning.
func AddAsIsPresigingMiddleware(stack *middleware.Stack) error {
func AddAsIsPresigningMiddleware(stack *middleware.Stack) error {
return stack.Initialize.Add(asIsPresigningMiddleware{}, middleware.Before)
}

Expand Down
2 changes: 1 addition & 1 deletion service/neptune/api_client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/polly/api_client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/rds/api_client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/s3/api_client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion service/sts/api_client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 530583e

Please sign in to comment.