docs(s3-request-presigner): add in getSignedUrl example with and without signed headers #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
trivikr
requested changes
May 23, 2024
whutchinson98
commented
May 30, 2024
There was a problem hiding this comment.
@trivikr I believe I've updated everything as requested. Please let me know if there is any other tweaks you would like me to make.
kuhe
approved these changes
Jun 17, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update documentation providing an example on using
getSignedUrlmethod with and without signed headers.Testing
N/A - docs
Additional context
While working on setting up presigned urls with signed headers I noticed there was a lack of documentation regarding how to handle
x-amz-*headers you wish to have signed. I hope this PR allows for others to find the solution quicker.Checklist
@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.