Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amazon Q Code Transform - Add 'unknown' type to BuildSystem and BuildCommand #798

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Amazon Q Code Transform - Add 'unknown' type to BuildSystem and BuildCommand #798

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef9231d
Add Unknown option for buildSystem and buildCommand
tincheng Jul 26, 2024
122e4f3
Make buildSystem and buildCommand optional in metrics
tincheng Jul 26, 2024
9473e05
revert description change for logGeneralError
tincheng Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,8 @@
"gradlew.bat",
"gradlew",
"gradle",
"IDEBundledGradle"
"IDEBundledGradle",
"unknown"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both VS and JB autogenerate the unknown type

]
},
{
Expand All @@ -298,7 +299,8 @@
"description": "Type of build system",
"allowedValues": [
"Maven",
"Gradle"
"Gradle",
"unknown"
]
},
{
Expand Down Expand Up @@ -3797,7 +3799,7 @@
"metadata" : [
{
"type": "codeTransformBuildCommand",
"required": true
"required": false
},
{
"type": "codeTransformSessionId",
Expand Down Expand Up @@ -4057,7 +4059,7 @@
},
{
"type": "codeTransformBuildSystem",
"required": true
"required": false
},
{
"type": "codeTransformLocalJavaVersion",
Expand Down
Loading