Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add latest instance types that support EFA #1151

Merged
merged 2 commits into from
Sep 21, 2024
Merged

chore: Add latest instance types that support EFA #1151

merged 2 commits into from
Sep 21, 2024

Conversation

bryantbiggs
Copy link
Member

Issue

  • N/A

Description of changes

  • Add latest instance types that support EFA

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pavani-Panakanti
Pavani-Panakanti reviewed Sep 20, 2024
View reviewed changes
stable/aws-efa-k8s-device-plugin/Chart.yaml Outdated
version: v0.5.4
appVersion: "v0.5.4"
version: v0.5.5
appVersion: "v0.5.5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appVersion should stay at "v0.5.4" which is the latest image version ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's keep appVersion same as the efa-plugin version so that we can keep a track

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes - makes sense. corrected in 7f82abe

jaydeokar
jaydeokar approved these changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@jaydeokar jaydeokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bryantbiggs bryantbiggs merged commit cf23219 into aws:master Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavani-Panakanti Pavani-Panakanti Pavani-Panakanti approved these changes

@jaydeokar jaydeokar jaydeokar approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5

@dims dims Awaiting requested review from dims dims is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryantbiggs @jaydeokar @Pavani-Panakanti