Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appmesh-prometheus] Add support for remote-write #978

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

egkelly
Copy link
Contributor

@egkelly egkelly commented Aug 1, 2023

Issue

#977

Description of changes

Add optional configuration for prometheus remote-write according to documentation for Prometheus v2.13. This will need to be changed when the chart installs Prometheus >= 2.26

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

Manually added the remote_write configuration with URL and bearer token directly to a running configuration of appmesh-prometheus and verified successful remote writing to (in my case) NewRelic.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@egkelly egkelly requested a review from a team as a code owner August 1, 2023 18:13
@BennettJames
Copy link
Contributor

BennettJames commented Aug 1, 2023

Hey egkelly, thanks for submitting a patch.

This looks pretty low risk, so I've approved and merged it.

@BennettJames BennettJames merged commit f5c5e1d into aws:master Aug 1, 2023
1 check passed
@egkelly
Copy link
Contributor Author

egkelly commented Aug 1, 2023

Thanks for the speedy PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants