Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rosetta): handle tablets with a streaming JSON codec #4034

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

RomainMuller
Copy link
Contributor

Tablet files can grow pretty large, and cache files even larger. In order to avoir running into the maximum string length node supports when encoding or decoding those, use a streaming JSON encoder / decoder.

Backports aws/jsii-rosetta#43


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Tablet files can grow pretty large, and cache files even larger. In
order to avoir running into the maximum string length node supports when
encoding or decoding those, use a streaming JSON encoder / decoder.

Backports aws/jsii-rosetta#43
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

Merging (with squash)...

@mergify mergify bot merged commit d2ecb6d into main Mar 30, 2023
@mergify mergify bot deleted the rmuller/streaming-json branch March 30, 2023 21:30
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 30, 2023
mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Apr 5, 2023
Pulling the rosetta [fix](aws/jsii#4034) that should fix the pipelines. Didn't do this through the upgrade workflow [PR](#24933) because it looks like there are other dependencies failing the build we don't want to be blocked on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants