Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rosetta): flakey trim-cache test #4043

Merged
merged 3 commits into from
Apr 5, 2023
Merged

fix(rosetta): flakey trim-cache test #4043

merged 3 commits into from
Apr 5, 2023

Commits on Apr 5, 2023

  1. fix(rosetta): flakey trim-cache test 

    It appears the trim-cache test using tablet compression occasionally
fails in CI/CD. I suspect this is due to the `save` function returning
before the GZip stream has bene closed, resulting in the subsequent read
attempting to consume an incomplete GZip object.

This adds the necessary provisions to ensure the GZip stream is closed
(or failed) before `save` returns.
    @RomainMuller
    RomainMuller committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d2c4c82 View commit details
    Browse the repository at this point in the history

  2. explicitly type method return, just await on Promise.all

    @RomainMuller
    RomainMuller committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    38189f2 View commit details
    Browse the repository at this point in the history

  3. use gzip as a transform

    @RomainMuller
    RomainMuller committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    71d23b5 View commit details
    Browse the repository at this point in the history