Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(superchain): switch to JDK 20 #4082

Merged
merged 5 commits into from
May 12, 2023
Merged

feat(superchain): switch to JDK 20 #4082

merged 5 commits into from
May 12, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 5, 2023

Switch to a more recent version of the JDK. jsii-pacmak will keep on targeting Java 1.8, so this doesn't affect compatibility of the generated class files.

What this will gain us is access to a more recent, optimized javadoc tool, which completes a lot faster than the one from JDK 8.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Switch to a more recent version of the JDK. `jsii-pacmak` will keep on
targeting Java 1.8, so this doesn't affect compatibility of the
generated class files.

What this will gain us is access to a more recent, optimized `javadoc`
tool, which completes a lot faster than the one from JDK 8.
@rix0rrr rix0rrr requested a review from a team May 5, 2023 09:16
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 5, 2023
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the OpenJDK entry in the "Included language SDKs" section of README.md

@rix0rrr
Copy link
Contributor Author

rix0rrr commented May 8, 2023

Confirmed that this builds javadocs On My Machine in a somewhat reasonable time, ~11mins:

[jsii-pacmak] [INFO] Packaged. java (11m53.6s) | go (2m10.3s) | python (2m9.5s) | dotnet (1m46.5s) | js (41.3s) | load jsii (16.2s) | npm pack (6.3s) | cleanup (0.0s)

Still need to check that the pipeline docs build works with this version of Javadoc, which it looks like it might not

@rix0rrr rix0rrr marked this pull request as ready for review May 10, 2023 13:04
@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label May 12, 2023
@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label May 12, 2023
@mergify
Copy link
Contributor

mergify bot commented May 12, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label May 12, 2023
@mergify
Copy link
Contributor

mergify bot commented May 12, 2023

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented May 12, 2023

Merging (with squash)...

@mergify mergify bot merged commit f0a1dfc into main May 12, 2023
@mergify mergify bot deleted the huijbers/java-20 branch May 12, 2023 19:04
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants