chore(runtime): correct return types for completeCallback and processRequest #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
TimothyJones
changed the title
RomainMuller
approved these changes
Jun 13, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type for
completeCallbackwas incorrectly listed asvoid, which confused me for a bit. This PR corrects it.Changes here:
completeCallbacktoapi.CompleteRequest['result'](wasvoid) as this is correct. Technically, this resolves toany- but I thoughtapi.CompleteRequest['result']was more explicit about what is actually happening.processRequestso that the return type is correct there, too.handleCallbackand explicit return types. This is personal preference - let me know if you'd prefer the functions left with implicit return types.As an aside, I was surprised the old version compiled, but it turns out you're allowed to return an
anyfrom a function marked as returningvoid. Makes sense as you can assignanyto anything, but it was a bit surprising.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.