s2n-tls rust binding: expose selected application protocol #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
reviewed
Jun 12, 2024
zh-jq-b
force-pushed
the
get_alpn
branch
3 times, most recently
from
cbe0841
to
8e36ebc
Compare
jmayclin
reviewed
Jun 14, 2024
jmayclin
approved these changes
Jun 15, 2024
lrstewart
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
none
Description of changes:
Add a Connection::selected_application_protocol() method to get the selected ALPN value.
Call-outs:
none
Testing:
Not yet. I didn't found any ALPN related testcases in s2n-tls/src/testing/s2n_tls.rs. Maybe I should add one?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.