Skip to content

Commit

Permalink
Fix a bunch of places we forget to aws_raise_error()
Browse files Browse the repository at this point in the history
  • Loading branch information
graebm committed Feb 9, 2024
1 parent b7a96fd commit 2b9f835
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion source/event_stream_channel_handler.c
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ static int s_process_write_message(
(void)slot;
(void)message;
AWS_FATAL_ASSERT(!"The event-stream-channel-handler is not designed to be a mid-channel handler.");
return AWS_OP_ERR;
return aws_raise_error(AWS_ERROR_UNIMPLEMENTED);
}

static int s_increment_read_window(struct aws_channel_handler *handler, struct aws_channel_slot *slot, size_t size) {
Expand Down
2 changes: 1 addition & 1 deletion source/event_stream_rpc_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ static int s_send_protocol_message(
struct event_stream_connection_send_message_args *args =
aws_mem_calloc(connection->allocator, 1, sizeof(struct event_stream_connection_send_message_args));

if (!message_args) {
if (!args) {
AWS_LOGF_ERROR(
AWS_LS_EVENT_STREAM_RPC_CLIENT,
"id=%p: failed to allocate callback arguments %s.",
Expand Down
2 changes: 1 addition & 1 deletion source/event_stream_rpc_server.c
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ static int s_send_protocol_message(
struct event_stream_connection_send_message_args *args =
aws_mem_calloc(connection->allocator, 1, sizeof(struct event_stream_connection_send_message_args));

if (!message_args) {
if (!args) {
AWS_LOGF_ERROR(
AWS_LS_EVENT_STREAM_RPC_SERVER,
"id=%p: allocation of callback args failed with error %s",
Expand Down

0 comments on commit 2b9f835

Please sign in to comment.