Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S3 Sample #321

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Update S3 Sample #321

merged 5 commits into from
Jun 27, 2023

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jun 26, 2023

Description of changes:

  • Update docs with sample instructions
  • Crash if list object fails

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@waahm7 waahm7 changed the title Update sample instructions Update S3 Sample Jun 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #321 (f1f0181) into main (1dbc4e9) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   88.88%   88.78%   -0.11%     
==========================================
  Files          17       17              
  Lines        4947     4938       -9     
==========================================
- Hits         4397     4384      -13     
- Misses        550      554       +4     

see 1 file with indirect coverage changes

@waahm7 waahm7 merged commit d1bbce9 into main Jun 27, 2023
29 checks passed
@waahm7 waahm7 deleted the update-sample branch June 27, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants