Fix MemoryLimit primary_allocated stat #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
changed the title
| @@ -232,6 +232,7 @@ void s_buffer_pool_trim_synced(struct aws_s3_buffer_pool *buffer_pool) { | |||
| aws_array_list_get_at_ptr(&buffer_pool->blocks, (void **)&block, i); | |||
|
|
|||
| if (block->alloc_bit_mask == 0) { | |||
| buffer_pool->primary_allocated -= block->block_size; | |||
There was a problem hiding this comment.
can you check if we have same bug in secondary allocated?
There was a problem hiding this comment.
I have checked and I think we don't have it https://github.com/awslabs/aws-c-s3/blob/main/source/s3_buffer_pool.c#L487.
DmitriyMusatkin
approved these changes
Sep 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 89.29% 89.31% +0.01%
==========================================
Files 20 20
Lines 6127 6128 +1
==========================================
+ Hits 5471 5473 +2
+ Misses 656 655 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.