Skip to content

Commit

Permalink
Fix support for pipelines running CodeBuild containers with Python < …
Browse files Browse the repository at this point in the history
…v3.10 (#705)

**Why?**

With the current dependency requirements, a build pipeline will fail to install
liburl3 if a Python version prior to v3.10 is used.

As botocore defined a Python version specific requirement for urllib3, as can
be seen at https://github.com/boto/botocore/blob/1.34.17/setup.py#L28-L29.

**What?**

If urllib3 is installed in a CodeBuild container which has Python version
< v3.10, we should use the latest 1.26 release that is available instead.
  • Loading branch information
sbkok authored Apr 5, 2024
1 parent 54a7f4d commit bbecd08
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ pyyaml~=6.0.1
schema~=0.7.5
tenacity==8.2.3
typing-extensions~=4.9.0
urllib3~=2.0.7
urllib3~=1.26.18 ; python_version < "3.10"
urllib3~=2.0.7 ; python_version >= "3.10"
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ pyyaml~=6.0.1
schema~=0.7.5
tenacity==8.2.3
typing-extensions~=4.9.0
urllib3~=2.0.7
urllib3~=1.26.18 ; python_version < "3.10"
urllib3~=2.0.7 ; python_version >= "3.10"

0 comments on commit bbecd08

Please sign in to comment.