Fix concurrent socket connection issue #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcnance
force-pushed
the
jared/#40-tcp-socket-errors
branch
from
6f1ab0d
to
e5a88c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
This makes the TCP client safe to use across threads by allowing only a single thread to connect at a time. Additionally, it adds a single connect+retry for messages that fail because of a disconnected peer. Note that there is currently an issue with the
test_can_recover_from_agent_shutdownthat is a result of the test socket not being properly cleaned between shutdown and resume. This causes the test agent to fail to start occasionally.