Bump the AWS SDK version to 2.22.12 and 1.12.633 to fix all vulnerabilities #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangSan0622
force-pushed
the
aws-sdk-version-update
branch
3 times, most recently
from
23b60a8
to
033ca1d
Compare
YangSan0622
force-pushed
the
aws-sdk-version-update
branch
from
033ca1d
to
240c2fd
Compare
blacktooth
reviewed
Jan 16, 2024
| @@ -97,6 +97,7 @@ public void testBuildConfig_fromMap_succeeds() { | |||
| public void testBuildConfig_noRegionConfigsSupplied_throwsException() { | |||
| Map<String, Object> configWithoutRegion = new HashMap<>(); | |||
| configWithoutRegion.put(AWSSchemaRegistryConstants.AWS_ENDPOINT, "https://test/"); | |||
| System.setProperty("aws.profile", ""); | |||
There was a problem hiding this comment.
Is this needed for localstack to run?
There was a problem hiding this comment.
no, this is needed because we updated AWS SDK versions, so we need to unset the system property for the test to pass as new AWS SDK will get region defined in profile now.
blacktooth
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Increasing the AWS SDK version to fix some vulnerabilities we have
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.