TaskDefinition.Options generated without field

[ndeloof]

after code has been regenerated on #296

TaskDefinition_LogConfiguration.Options, which was previously a map[string]string, now is implemented as a *TaskDefinition_Options, but the latter has no field that can be used to pass options

[ndeloof]

I wonder this is an issue with the schema, as "AWS::ECS::TaskDefinition.Options" is declared with additionalProperties: false
Was previously:

"Options": {
                    "additionalProperties": true,
                    "patternProperties": {
                        "^[a-zA-Z0-9]+$": {
                            "type": "string"
                        }
                    },
                    "type": "object"
                }

[ndeloof]

Looking at cloudformation schema https://d1uauaxba7bl26.cloudfront.net/latest/gzip/CloudFormationResourceSpecification.json I can't find the definition for the Options type.

[jonahjon]

Looking at cloudformation schema https://d1uauaxba7bl26.cloudfront.net/latest/gzip/CloudFormationResourceSpecification.json I can't find the definition for the Options type.

Where did you get this link from? When I dig into the link https://d1uauaxba7bl26.cloudfront.net/ it looks like the most recent version is from 2017, if the XML "" tag is correct. I do see the change made to the Docs though that supports this claim awsdocs/aws-cloudformation-user-guide@cb59b66.

I tested a fargate stack, and the "AWS::ECS::TaskDefinition.Options" still works when included in the cloudformation template so I'm unsure but will ask internally to try to figure more out.

[ndeloof]

This is the one used by generate : https://github.com/awslabs/goformation/blob/master/generate/main.go#L13

[jonahjon]

This is the one used by generate : https://github.com/awslabs/goformation/blob/master/generate/main.go#L13

Ok, cool makes sense

[PaulMaddox]

The CloudFormation schema has the following, which looks correct to me at first glance.

It should be generating a map[string]string in goformation. Let me do some further investigation to work out what is going wrong here...

"AWS::ECS::TaskDefinition.LogConfiguration": {
    "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-containerdefinitions-logconfiguration.html",
    "Properties": {
    "LogDriver": {
        "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-containerdefinitions-logconfiguration.html#cfn-ecs-taskdefinition-containerdefinition-logconfiguration-logdriver",
        "UpdateType": "Immutable",
        "Required": true,
        "PrimitiveType": "String"
    },
    "Options": {
        "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-containerdefinitions-logconfiguration.html#cfn-ecs-taskdefinition-containerdefinition-logconfiguration-options",
        "UpdateType": "Immutable",
        "Required": false,
        "Type": "Map",
        "PrimitiveItemType": "String"
    },
    "SecretOptions": {
        "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-containerdefinitions-logconfiguration.html#cfn-ecs-taskdefinition-logconfiguration-secretoptions",
        "UpdateType": "Immutable",
        "Required": false,
        "Type": "List",
        "ItemType": "Secret"
    }
    }
},

[PaulMaddox]

It looks like this was actually corrected last night in the upstream CloudFormation specification, and the goformation code is generating properly now.

Unfortunately there is another CloudFormation schema issue introduced that is causing our tests to fail and blocking a release. See issue #300. I have raised this internally.

[PaulMaddox]

Fixed in #320