-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudFormation Schema Issues #300
Comments
If the CloudFormation Resource Specification has a resource property that does not include any type information then this should be a breaking error and generation should fail. See awslabs#300
* Check for properties with no type in CFN spec If the CloudFormation Resource Specification has a resource property that does not include any type information then this should be a breaking error and generation should fail. See #300
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
If a resource property is missing a type in the CloudFormation Resource Specification (see #300), then autofix it to type = 'Json', which will in turn set it to interface{} in the generated Go structs. Do this instead of blocking all builds on missing type information.
* fix(generator): autofix missing property types If a resource property is missing a type in the CloudFormation Resource Specification (see #300), then autofix it to type = 'Json', which will in turn set it to interface{} in the generated Go structs. Do this instead of blocking all builds on missing type information. * chore(ci): allow manual trigger of schema update
This still has not been resolved upstream in the CloudFormation Resource Specification. I have put in place a workaround in #314. Instead of blocking resource generation when properties are found with missing type information, we instead set the type to This is an example of the output where the autofixing is logged:
|
@rubenfonseca I believe this is solved as well all resources have PrimitiveType |
Thanks! |
The latest CloudFormation schema published (2020-08-25) has two issues:
AWS::ECR::Repository.RepositoryPolicyText
has noPrimiviteType
(or any type).AWS::KMS::Key.KeyPolicy
has noPrimitiveType
(or any type).source: https://d1uauaxba7bl26.cloudfront.net/latest/gzip/CloudFormationResourceSpecification.json
This causes tests to fail after code generation:
Ticket raised with CloudFormation team to have this corrected.
The text was updated successfully, but these errors were encountered: