CloudFormation Resource Specification 18.1.0 #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
kddejong
force-pushed
the
update/specs2020.08.28
branch
from
eca0f4f
to
361e220
Compare
kddejong
force-pushed
the
update/specs2020.08.28
branch
from
361e220
to
b600e4e
Compare
PatMyron
reviewed
Sep 1, 2020
Comment on lines
+154
to
163
| { | ||
| "op": "add", | ||
| "path": "/ResourceTypes/AWS::ECR::Repository/Properties/RepositoryPolicyText/PrimitiveType", | ||
| "value": "Json" | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/ResourceTypes/AWS::KMS::Key/Properties/KeyPolicy/PrimitiveType", | ||
| "value": "Json" | ||
| } |
There was a problem hiding this comment.
matches snippets from previous 17.0.0 Resource Specification 👍
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Sep 17, 2020
Patches partially inspired by: - https://github.com/aws-cloudformation/cfn-python-lint/pull/1697/files - aws-cloudformation/cfn-lint#1671 BREAKING CHANGE: Fixed ECS task definition within the L1 layer. Fixed the casing of the `efsVolumeConfiguration` property to match the spec published by cloudformation. Fixed the type of the `DockerVolumeConfiguration.labels` property to allow users to properly apply labels. * **ecs**: Task definitions configured with an `efsVolumeConfiguration` will incur a resource replacement due to wrong casing of the underlying resources introduced in this [PR](https://github.com/aws/aws-cdk/pull/8467/files). This replacement will in turn cause a rolling update to any running tasks that use that definition. * **ecs**: `DockerVolumeConfiguration.labels` changed from an **array** to a **map**. This was a long standing latent bug and in fact configuring labels in the old format would have resulted in the wrong behavior.
PatMyron
changed the title
eladb
pushed a commit
to cdklabs/decdk
that referenced
this pull request
Jan 18, 2022
Patches partially inspired by: - https://github.com/aws-cloudformation/cfn-python-lint/pull/1697/files - aws-cloudformation/cfn-lint#1671 BREAKING CHANGE: Fixed ECS task definition within the L1 layer. Fixed the casing of the `efsVolumeConfiguration` property to match the spec published by cloudformation. Fixed the type of the `DockerVolumeConfiguration.labels` property to allow users to properly apply labels. * **ecs**: Task definitions configured with an `efsVolumeConfiguration` will incur a resource replacement due to wrong casing of the underlying resources introduced in this [PR](https://github.com/aws/aws-cdk/pull/8467/files). This replacement will in turn cause a rolling update to any running tasks that use that definition. * **ecs**: `DockerVolumeConfiguration.labels` changed from an **array** to a **map**. This was a long standing latent bug and in fact configuring labels in the old format would have resulted in the wrong behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.