feat(cfnspec): cloudformation spec v18.3.0 #10385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
reviewed
Sep 16, 2020
| @@ -328,6 +328,32 @@ export class TaskDefinition extends TaskDefinitionBase { | |||
| return this._executionRole; | |||
| } | |||
|
|
|||
| private renderVolumes(): CfnTaskDefinition.VolumeProperty[] { | |||
iliapolo
reviewed
Sep 16, 2020
| @@ -713,7 +739,7 @@ export interface DockerVolumeConfiguration { | |||
| * | |||
| * @default No labels | |||
| */ | |||
| readonly labels?: string[]; | |||
| readonly labels?: { [key: string]: string; } | |||
iliapolo
reviewed
Sep 16, 2020
| @@ -1006,8 +1006,8 @@ export = { | |||
| Family: 'Ec2TaskDef', | |||
| Volumes: [{ | |||
| Name: 'scratch', | |||
| EfsVolumeConfiguration: { | |||
| FileSystemId: 'local', | |||
| EFSVolumeConfiguration: { | |||
MrArnoldPalmer
added
the
pr/do-not-merge
MrArnoldPalmer
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Approved with do-not-merge. Wanted to give @RomainMuller a chance to check this out.
RomainMuller
approved these changes
Sep 17, 2020
RomainMuller
removed
the
pr/do-not-merge
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches partially inspired by:
BREAKING CHANGE: Fixed ECS task definition within the L1 layer. Fixed the casing of the
efsVolumeConfigurationproperty to match the spec published by cloudformation. Fixed the type of theDockerVolumeConfiguration.labelsproperty to allow users to properly apply labels.efsVolumeConfigurationwill incur a resource replacement due to wrong casing of the underlying resources introduced in this PR. This replacement will in turn cause a rolling update to any running tasks that use that definition.DockerVolumeConfiguration.labelschanged from an array to a map. This was a long standing latent bug and in fact configuring labels in the old format would have resulted in the wrong behavior.