Merge pull request #23 from buddhike/fix/re-parameter

Use RuntimeEnvironment specified in template args when creating MSF app
awslabs · Mar 12, 2024 · d529b9d · d529b9d
2 parents ff07c39 + 6ee461f
commit d529b9d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/apps/java-datastream/kds-to-s3-datastream-java/cdk-infra/lib/cdk-infra-kds-to-s3-stack.ts b/apps/java-datastream/kds-to-s3-datastream-java/cdk-infra/lib/cdk-infra-kds-to-s3-stack.ts
@@ -136,7 +136,7 @@ export class CdkInfraKdsToS3Stack extends cdk.Stack {
       region: this.region,
       partition: this.partition,
       appName: cfnParams.get("AppName")!.valueAsString,
-      runtimeEnvironment: MsfRuntimeEnvironment.FLINK_1_18,
+      runtimeEnvironment: cfnParams.get("RuntimeEnvironment")!.valueAsString,
       serviceExecutionRole: appRole.roleArn,
       bucketName: cfnParams.get("BucketName")!.valueAsString,
       jarFile: cfnParams.get("JarFile")!.valueAsString,
@@ -225,7 +225,7 @@ export class CdkInfraKdsToS3Stack extends cdk.Stack {
 
     params.set("RuntimeEnvironment", new cdk.CfnParameter(this, "RuntimeEnvironment", {
       type: "String",
-      default: "FLINK-1_15",
+      default: MsfRuntimeEnvironment.FLINK_1_18.toString(),
       description: "Flink runtime environment"
     }));
 

diff --git a/cdk-infra/shared/lib/msf-java-app-construct.ts b/cdk-infra/shared/lib/msf-java-app-construct.ts
@@ -19,7 +19,7 @@ export interface MsfJavaAppProps extends StackProps {
     region: string;
     partition: string;
     appName: string;
-    runtimeEnvironment: MsfRuntimeEnvironment,
+    runtimeEnvironment: string,
     serviceExecutionRole: string;
     bucketName: string;
     jarFile: string;