-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback PR #10
Open
axelmagn
wants to merge
21
commits into
candidate
Choose a base branch
from
feedback
base: candidate
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feedback PR #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an MLOps Manager that may be used to create simple vertex AI applications. Key additions: * `mlops_manager start_app` command * `hello_pipeline` example pipeline * cloud build config in `config/build/cloudbuild.yaml`
fashion-mnist classifier pipeline that can be invoked via cloud build
- build_pipeline command to build pipeline from config - PipelineRunner to encapsulate pipeline management logic - first tests for PipelineRunner - tests throw warnings that I cannot replicate when invoking by command. Currently confused as to why.
- run_pipeline command and runner function - update run_pipeline.yaml cloud build config
- naming refactor - fashion_mnist uses app image - pipeline runner renamed to harness - Remove dependency of docker image on sdist for speed - Vertex custom training job
- create new pipelines template - improve templating logic to be more extensible
Give existing examples a more regular format.
- Add standalone task decorator. - task decorator that can be used to quickly annotate trainer tasks - add pylintrc (not yet conformant) - convert fashion_mnist trainer task to use decorator - implement build, release, and deploy configs for cloud build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mega-PR of all of my work so far. Please feel free to provide feedback in the form of both thread comments and inline code comments. All feedback will be considered and responded to. While reviewing, please consider the following questions:
I will integrate requested changes into the feedback branch, and coordinate with participants until we reach a point where designated reviewers have provided their LGTM.