trie: refactor tracer #581
Open
+1,109
−442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francesco4203
commented
Sep 20, 2024
| order = append(order, owner) | ||
| } | ||
| if _, ok := nodes.sets[common.Hash{}]; ok { | ||
| order = append(order, common.Hash{}) |
There was a problem hiding this comment.
Here, the trie with owner empty representing the account trie is pushed to the back of the array so that all the storage dirty nodes are flushed first.
Reference: ethereum/go-ethereum@5758d1f
Francesco4203
commented
Sep 20, 2024
| @@ -628,16 +630,16 @@ func (t *Trie) Commit(collectLeaf bool) (common.Hash, *NodeSet, error) { | |||
| } | |||
|
|
|||
| // hashRoot calculates the root hash of the given trie | |||
| func (t *Trie) hashRoot() (node, node, error) { | |||
| func (t *Trie) hashRoot() (node, node) { | |||
There was a problem hiding this comment.
No error will ever be returned, so just not return error here.
Francesco4203
force-pushed
the
rework-tracer
branch
from
6e8c795
to
ab303f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: ethereum/go-ethereum#26763
Also applied some related changes from this PR: ethereum/go-ethereum#27160
Changes:
trie/utils.gototrie/tracer.gooriginfield intracertoaccessList, still the same functionmarkUpdatedandmarkDeletedintoaddNodecommitter: move logic to mark deleted nodes tocommitter.storefor consistency with the mark update logic