Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to Docker image #267

Closed
TobiX opened this issue Mar 18, 2024 · 5 comments
Closed

Add labels to Docker image #267

TobiX opened this issue Mar 18, 2024 · 5 comments
Labels
docker Docker builds and images

Comments

@TobiX
Copy link

TobiX commented Mar 18, 2024

Hi!

First: Thanks for this tool. I have switched from MailHog und really like all the new features (tags, dark theme, etc.)

I currently have just a small request: Could you add some labels to the Docker image?

I think a fairly uncontroversial set would be:

LABEL org.opencontainers.image.source="https://github.com/axllent/mailpit" \
  org.opencontainers.image.url="https://mailpit.axllent.org/" \
  org.opencontainers.image.licenses="MIT"

This helps tools like Renovate (and Dependabot?) to link and embed changelogs into update PRs (for example when using docker images in Helm charts)

@axllent
Copy link
Owner

axllent commented Mar 18, 2024

Thanks for this, I'll look into it and add something in the near future 👍

@axllent
Copy link
Owner

axllent commented Mar 23, 2024

I've added the following to the Dockerfile:

LABEL org.opencontainers.image.title="Mailpit" \
  org.opencontainers.image.description="An email and SMTP testing tool with API for developers" \
  org.opencontainers.image.source="https://github.com/axllent/mailpit" \
  org.opencontainers.image.url="https://mailpit.axllent.org" \
  org.opencontainers.image.documentation="https://mailpit.axllent.org/docs/" \
  org.opencontainers.image.licenses="MIT"

I trust this will be sufficient?

Unless you have good reason to require this "now", I'll wait until I have a few more changes before releasing a new version 👍

@TobiX
Copy link
Author

TobiX commented Mar 23, 2024

Thanks! I think that's reasonable.

@axllent
Copy link
Owner

axllent commented Mar 30, 2024

This has finally been released in v1.15.1 👍

Please confirm it works as you expect?

@axllent axllent added the docker Docker builds and images label Mar 30, 2024
@axllent axllent closed this as completed Apr 6, 2024
@TobiX
Copy link
Author

TobiX commented Apr 7, 2024

Sorry for the late reply, can confirm it works now, see TobiX/test-renovate-stuff#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker builds and images
Projects
None yet
Development

No branches or pull requests

2 participants