Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags from headers don't respect RFC 2047 encoding #344

Closed
ScopeyNZ opened this issue Aug 8, 2024 · 5 comments
Closed

Tags from headers don't respect RFC 2047 encoding #344

ScopeyNZ opened this issue Aug 8, 2024 · 5 comments

Comments

@ScopeyNZ
Copy link

ScopeyNZ commented Aug 8, 2024

If you send a UTF-8 (for example) encoded header value for X-Tags then the tag you get will include the encoding artifacts:

image
image

@axllent
Copy link
Owner

axllent commented Aug 8, 2024

I'm not sure why anyone would UFT8-encode the X-Tags values when UTF8 characters are not supported? Can you please explain the reasoning for UFT8-encoding them in the first place?

@ScopeyNZ
Copy link
Author

ScopeyNZ commented Aug 8, 2024

UTF-8 encoding is just a side effect of the mailing service we use and us requiring other headers to be UTF-8 encoded. You're right that we can work around this on our end by specifically not encoding this header, but I assumed that it might be of interest to have this report here as a record (and I also hoped that it would be somewhat trivial to address 😅).

@axllent
Copy link
Owner

axllent commented Aug 8, 2024

Ahh, I see your point. I'll look into this and see what, if anything, be done about it 👍

@axllent
Copy link
Owner

axllent commented Aug 10, 2024

This has feature been released as part of v1.20.1. It should correctly decode a mime-encoded X-Tag header now, even if that means stripping them of non-supported characters (assuming it contained that). Please let me know if this resolves your issue?

tmeijn pushed a commit to tmeijn/dotfiles that referenced this issue Aug 10, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [axllent/mailpit](https://github.com/axllent/mailpit) | minor | `v1.19.3` -> `v1.20.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>axllent/mailpit (axllent/mailpit)</summary>

### [`v1.20.1`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1201)

[Compare Source](axllent/mailpit@v1.20.0...v1.20.1)

##### Chore

-   Shift inbox pagination to inbox component
-   Live load up to 100 new messages in sidebar ([#&#8203;336](axllent/mailpit#336))
-   Show icon attachment in new side navigation message listing ([#&#8203;345](axllent/mailpit#345))

##### Fix

-   Correctly decode X-Tags message headers (RFC 2047) ([#&#8203;344](axllent/mailpit#344))

### [`v1.20.0`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1200)

[Compare Source](axllent/mailpit@v1.19.3...v1.20.0)

##### Feature

-   Add option to control message retention by age ([#&#8203;338](axllent/mailpit#338))
-   **UI:** List messages in side nav when viewing message for easy navigation ([#&#8203;336](axllent/mailpit#336))

##### Chore

-   Update caniemail database
-   Update Go dependencies
-   Update node dependencies
-   Make internal tagging methods private

##### Fix

-   Prevent potential JavaScript errors caused by race condition
-   Better regexp to detect tags in search
-   Prevent Vue race condition to initialize dayjs relativeTime plugin
-   **API:** Return `text/plain` header for message delete request

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
@ScopeyNZ
Copy link
Author

ScopeyNZ commented Aug 14, 2024

Thanks for addressing this so quickly! I can confirm that it's resolved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants