Conversion to async #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
g2p
force-pushed
the
async
branch
2 times, most recently
from
cbf3897
to
5b1a75a
Compare
It is possible to get by with matches!, but this is more convenient.
On the JS sender side at least, Session.queueLoad is deprecated in favour of Session.load with a queueData set on the loaded item.
This is useful to know when the player appears to be idle but is in fact loading the next track from a playlist.
Also, introduce the TryFrom trait and new error types. This removes all uses of unwrap from media.rs.
Queue item currently playing, loading, preloaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a branch that converts rust-cast to an async message stream. The interesting changes are in src/message_manager.rs (going from Read+Write to AsyncRead+AsyncWrite) and src/lib.rs (connecting is changed to use tokio-rustls); the rest is simple changes from fns to async fns. Sending and receiving won't block each other.
It is on top of my other patches; to review the async changes, please look at g2p/queue-load...g2p/async
Draft for now because the latest release of tokio-rustls is behind the current version of rustls (which rust-cast uses), and for now Cargo.toml points to the main branch of tokio-rustls.